Use a digit-only input for spool ID #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets spool ID field to input type DIGIT and adds support in the on-screen keyboard for this input type. They on-screen keyboard can now display a number pad instead of the standard keyboard if the widget requesting the keyboard has input type DIGIT.
|
Hi, this is a great addition, but really this is a change the the base Klipperscreen. Can you also submit this PR to the upstream klipperscreen so I don't have to continually keep in sync. I think it will be welcomed, but if not, leave the PR hear and I can consider.. |
Yup, fair enough! I sent in a PR to upstream KlipperScreen. If that gets accepted, I can update this one to be just the one-line change in mmu_filaments.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets spool ID field to input type DIGIT and adds support in the on-screen keyboard for this input type. They on-screen keyboard can now display a number pad instead of the standard keyboard if the widget requesting the keyboard has input type DIGIT.
I got tired of having to press another button and navigate the number row on the on-screen keyboard. The existing KlipperScreen keyboard didn't support any InputType hinting. Special layout behavior was added for the DIGIT input type so that columns are aligned properly (instead of being offset like the normal keyboard).
It looks like this:
