Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Add mypy checks for modin.core.dataframe.algebra #5167

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yashgosa
Copy link

@yashgosa yashgosa commented Oct 31, 2022

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@yashgosa yashgosa requested a review from a team as a code owner October 31, 2022 15:43
@yashgosa yashgosa changed the title trying did some progress REFACTOR: Add mypy checks for modin.core.dataframe.algebra Oct 31, 2022
@yashgosa yashgosa requested review from a team as code owners October 31, 2022 16:08
@yashgosa
Copy link
Author

@pyrito @mvashishtha guys I aint able to understand why is this error occurring

modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "query_compiler"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "by"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "map_func"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "reduce_func"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "axis"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "groupby_kwargs"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "agg_args"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "agg_kwargs"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "drop"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "method"  [misc]
modin\core\dataframe\algebra\groupby.py:74:40: error: "caller" of "GroupByReduce" gets multiple values for keyword argument "default_to_pandas_func"  [misc]

@lgtm-com
Copy link

lgtm-com bot commented Oct 31, 2022

This pull request introduces 1 alert when merging 797a888 into 6f0ff79 - view on LGTM.com

new alerts:

  • 1 for Unused import

@yashgosa
Copy link
Author

This pull request introduces 1 alert when merging 797a888 into 6f0ff79 - view on LGTM.com

new alerts:

  • 1 for Unused import

@pyrito can you please help me out

@yashgosa
Copy link
Author

yashgosa commented Nov 1, 2022

@mvashishtha can you please review the code now I don't think so there should be any issues, if there are some changes required do tell me

@mvashishtha
Copy link
Collaborator

@sofezticated-gentleman I still see quite a lot of formatting changes, e.g. in modin/_compat/pandas_api/py36/base.py. Could you please revert all those and push to your branch again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants