Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ModinDataframe be a parent of PandasDataframe? #7244

Open
anmyachev opened this issue May 8, 2024 · 2 comments
Open

Should ModinDataframe be a parent of PandasDataframe? #7244

anmyachev opened this issue May 8, 2024 · 2 comments
Labels
Internals Internal modin functionality P2 Minor bugs or low-priority feature requests

Comments

@anmyachev
Copy link
Collaborator

ModinDataframe looks almost unused.
@anmyachev anmyachev added P2 Minor bugs or low-priority feature requests Internals Internal modin functionality labels May 8, 2024
@anmyachev anmyachev mentioned this issue May 8, 2024
Merged
7 tasks
@YarShev
Copy link
Collaborator

YarShev commented May 13, 2024

I think so since ModinDataframe declares the df algebra and PandasDataframe implements it.

@noloerino
Copy link
Collaborator

Seems like this was previously attempted back in #3998, hard to tell at a glance why it didn't end up happening though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internals Internal modin functionality P2 Minor bugs or low-priority feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noloerino @YarShev @anmyachev