Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-sort when adding filters #24

Open
richardlin047 opened this issue Mar 6, 2021 · 0 comments
Open

Don't re-sort when adding filters #24

richardlin047 opened this issue Mar 6, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@richardlin047
Copy link
Collaborator

Currently, sorts are applied again after a filter is applied. As a performance enhancement, when a more restrictive filter is applied on the df, there is no need to re-sort. This may not be feasible if each additional filter is done on the unfiltered_df rather than the internal df.

We could refactor to apply filters onto the internal df, but this is a trade-off of inefficiency when replaying code and minimizing relevant history code vs. performance of widget.

@richardlin047 richardlin047 added the enhancement New feature or request label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant