Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mypy to ci (but ignore for now), add numpy typing plugin #26

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ on:
- '**.md'
- '.gitignore'
jobs:
lint:
name: Lint
check:
name: Check
runs-on: ubuntu-latest
steps:

Expand All @@ -30,8 +30,15 @@ jobs:
- name: Install Python packages
run: pip install ".[lint]"

- name: Run ruff
- name: Linter
run: ruff check .

- name: Formatter
run: ruff format --check

# TODO: enable when passing
# - name: Type checker
# run: mypy flopy4

build:
name: Build
Expand Down
7 changes: 7 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,10 @@ ignore = [
"F821", # undefined name TODO FIXME
"E722" # do not use bare `except`
]

[tool.mypy]
packages = ["flopy4"]
modules = ["test"]
plugins = [
"numpy.typing.mypy_plugin"
]