Refactor slow benchcomp regression tests #2412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the regression tests that run Kani into a separate suite that runs after the other regression tests, so that users get quick feedback about any of the fast tests that fail.
celinval
reviewed
May 2, 2023
| @@ -607,3 +527,91 @@ def test_env(self): | |||
| result["benchmarks"]["suite_1"]["variants"][ | |||
| "env_unset"]["metrics"]["foos"], 0, | |||
| msg=yaml.dump(result, default_flow_style=False)) | |||
|
|
|||
|
|
|||
| class ZPerfRegressionTests(): | |||
There was a problem hiding this comment.
Can you please add a comment to what this is testing? BTW, is the "Z" a typo or some sort of naming convention?
There was a problem hiding this comment.
Also, is there a reason why this is not deriving unittest.TestCase?
|
|
||
| class ZPerfRegressionTests(): | ||
| def setUp(self): | ||
| self.kani_dir = pathlib.Path(__file__).parent.parent.parent.parent |
There was a problem hiding this comment.
please add a comment on the current structure. I.e., why does this have 4 parents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the regression tests that run Kani into a separate suite that runs after the other regression tests, so that users get quick feedback about any of the fast tests that fail.
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.