Remove duplicated CBMC Viewer version string

[karkhaz]

This ensures that the version string does not need to be updated in two places, either manually or via a release script.

Testing:

$ source kani-dependencies
$ echo $CBMC_VIEWER_VERSION                                                           
3.8

Checklist

• Each commit message has a non-empty body, explaining why the change was made
• Methods or procedures are documented
• Regression or unit tests are included, or existing tests cover the modified code
• My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

[jaisnan]

Thanks!

[zhassan-aws]

We wanted to use kani-dependencies as the single source of truth for versions of dependencies, so I would rather keep the version explicit here and instead update src/setup.rs to read the version from this file.

[jaisnan]

Thanks for catching that.

[karkhaz]

@zhassan-aws as part of @jaisnan's release script work, we will also need to store the GitHub repositories of each of these tools somewhere. It would be nice not to have to store them in two different places.

Can I suggest that we convert this file into JSON? The file is only ever used from the various install_*.sh scripts that run in CI. Thus, we could continue to read the versions if the CI has jq available. My proposal is to write the file like this:

{
  "CBMC_VIEWER": {
    "version": "3.8",
    "url": "https://github.com/model-checking/cbmc-viewer",
  }
}

Then install_cbmc.sh would do

CBMC_VERSION=$(jq -e CBMC.version < kani-dependencies.json)

and setup.rs would also parse the file with a JSON parser to find the CBMC Viewer version.

What do you think?

[zhassan-aws]

Converting it to a JSON file is definitely a good idea.

[celinval]

Actually, I don't understand why we want JSON here.