Inconsistent release 1.6.17

[froth]

Scala steward informed me about a new release 1.6.17.
Looking at https://search.maven.org/search?q=mockito-scala it seems that something went wrong in the process, some packages have the new version some the old. Even mixing for different scala versions.

Not a real problem for me, but I thought you might to know (if you did not already noticed it)

[ultrasecreth]

I noticed the release job failed yesterday, but on the bintray stage, didn't know that the maven release was corrupted...
As it was a dependency update I didn't pay that much attention, but what you say actually is a problem, gonna have to summon @mockitoguy here, as I'm not really familiar with the release process

Thanks for reporting it!

[mockitoguy]

Hey guys! This is a little strange.

• "mockito-scala_2.13:1.16.17" has been published to central (proof) but it does not show up in search.maven.org.
• "mockito-scala_2.12:1.16.17" (and 2.11) has not been published to Bintray, and therefore is missing from Central.

@bbonanno, what are the expected covariants of Scala we should be publishing?

[omarkilani]

For whatever reason, the .pom is missing from the published artifact:

https://dl.bintray.com/mockito/maven/org/mockito/mockito-scala_2.13/1.16.17/

Note that the .pom.md5 is there, so that's a little strange.

[mockitoguy]

The problem is that the CI build failed to publish all artifacts (details). My theory is that it's a bug in Gradle Bintray plugin: when one of the bintrayUpload tasks fails, the bintrayPublish task should not run (e.g. this looks like a bug in plugins handling of Gradle's finalizedBy/dependsOn). I haven't though about a remedy for this yet.

[mockitoguy]

@bbonanno, [ci skip] does not work, we need to use [skip ci], see the CI configuration. Same goes for skipping releases, it needs to be [skip release] ("skip" goes first ;-)).

[ultrasecreth]

@mockitoguy yeah, I noticed that after I merged, but in any case, it should have done a full release right? (I didn't care cause a full release out of that PR was not the end of the world).
I also noticed a PR failed the build on just the bintray upload (which is weird, why is a PR uploading anything)

The full release is a cartesian product of all the modules that produce a Jar x the 3 Scala versions we support

[ultrasecreth]

I just merged another PR, no comments, so let's see how the release goes

[froth]

went good :) the new release is consistent

[ultrasecreth]

Nice, let's hope it doesn't happen again!

[ultrasecreth]

Had to release again (another fix was made to the lib) so if that one's also successful I'll close this issue

[mockitoguy]

Hey @bbonanno, let's keep this open for a little bit because the root cause is not fixed. I reported a bug to Bintray plugin: bintray/gradle-bintray-plugin#340

[ultrasecreth]

@mockitoguy oh, fair enough

[ultrasecreth]

@mockitoguy this thing got worse, the last 3 master builds all hung and got cancelled after being stuck in the release step for a while

[mockitoguy]

I will look into this. We need to migrate off bintray anyway.

[ultrasecreth]

another failed release :(
https://github.com/mockito/mockito-scala/runs/2657755557?check_suite_focus=true

[ultrasecreth]

Hi @mockitoguy, sorry to bother but I noticed that even the PR builds are failing now on the Bintray upload, did something change around that?

[mockitoguy]

Will take a look!

On Thu, Jul 29, 2021 at 11:02 Bruno Bonanno ***@***.***> wrote: Hi @mockitoguy <https://github.com/mockitoguy>, sorry to bother but I noticed that even the PR builds are failing now on the Bintray upload, did something change around that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#351 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGBJ5GFNWX75URTMSJEDTT2EKKXANCNFSM4WWQDBGQ> .

-- Szczepan (Stefan) Faber Creator of Mockito <http://mockito.org> | Maker of Open Source on GitHub <https://github.com/mockitoguy> Check out how to give great code reviews <https://thenewstack.io/linkedin-code-review>. You will be glad you did!

[ultrasecreth]

Hi @mockitoguy, sorry to be annoying but now no release at all can be made, and PRs don't build anymore as the bintrayUpload always fails... seems to be related to credentials according to the error, but there isn't much I can do here, would you mind to have a look :)

Cheers!!!

[mockitoguy]

I'll make a commitment and resolve it by the end of this week. Will this work? Thanks for your patience! I've been traveling.

[ultrasecreth]

@mockitoguy sure, no worries, enjoy your trip :)

[mockitoguy]

Let's track this in #320