Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/unit-tests/margo-scheduling should hard fail on high CPU usage #250

Open
carns opened this issue Feb 13, 2023 · 3 comments
Open

tests/unit-tests/margo-scheduling should hard fail on high CPU usage #250

carns opened this issue Feb 13, 2023 · 3 comments
Assignees
@carns
Labels
testing Something needs to be done with tests

Comments

@carns
Copy link
Member

carns commented Feb 13, 2023

This test case already measures CPU utilization during mutex contention but just emits the result as advisory information on stderr. Once #249 is merged, then we should confirm that it produces the correct result when executed against [email protected] and make the test hard fail if CPU utilization is too high.

This should be done before rebasing and validating the new external thread test in #247 .
@carns carns self-assigned this Feb 13, 2023
@carns
Copy link
Member Author

carns commented Feb 14, 2023

Whoops, correction. This is not present in 1.1. We still need a new tagged point release of Argobots before making this change.

@carns carns removed their assignment Feb 14, 2023
@carns carns mentioned this issue Feb 14, 2023
Open
@mdorier mdorier added the testing Something needs to be done with tests label Feb 28, 2023
@carns
Copy link
Member Author

carns commented Aug 8, 2023

this should be resolved with argobots 1.2rc1 present in the mochi-spack-packages repo now. Will retest, and maybe adjust the PR so that this test is only enabled if argobots >= 1.2 is detected.

@carns
Copy link
Member Author

carns commented Aug 8, 2023

Whoops there is no PR. I'll make a new one to get that behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carns carns

Labels
testing Something needs to be done with tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdorier @carns