Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licenses versions #569

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Update licenses versions #569

merged 1 commit into from
Apr 5, 2022

Conversation

mat007
Copy link
Contributor

@mat007 mat007 commented Apr 5, 2022

https://github.com/mirage/mirage-channel/releases/tag/v4.1.0 was released a few hours ago.

I’m still a bit puzzled as to why the dependencies aren’t pinned. What did I miss? 🤔

Copy link
Collaborator

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Yeah we probably should pin some of these again.

@mat007
Copy link
Contributor Author

mat007 commented Apr 5, 2022

CircleCI build doesn’t agree that the versions need to be bumped

Fatal error: exception Failure("unknown licenses for ppx_cstruct.6.0.1, mirage-channel.4.0.1, cstruct-sexp.6.0.1, cstruct-lwt.6.0.1, cstruct.6.0.1")

🤔

@djs55
Copy link
Collaborator

djs55 commented Apr 5, 2022

Hm, not sure if that's because of non-determinism in the package manager's SAT solver (😬 )or something else. I'll take a look at pinning.

@mat007
Copy link
Contributor Author

mat007 commented Apr 5, 2022

or something else

Maybe there is a diamond style dependency with both versions still being needed.

Signed-off-by: Docker Desktop <[email protected]>
@djs55
Copy link
Collaborator

djs55 commented Apr 5, 2022

As an experiment I've added version pins for the direct dependencies in this PR: #570

There may be indirect dependencies too but I don't have a nice way to pin those, except by making them direct dependencies. I suspect it's the direct dependencies that change the most often (like the ones in this PR).

@djs55
Copy link
Collaborator

djs55 commented Apr 5, 2022

CI is green on Mac and Win (ocaml-ci is known to be broken)

@djs55 djs55 merged commit 61075db into moby:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants