Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdy_test.go:146: No error closing bad stream #74

Open
eclipseo opened this issue May 9, 2019 · 1 comment
Open

spdy_test.go:146: No error closing bad stream #74

eclipseo opened this issue May 9, 2019 · 1 comment

Comments

@eclipseo
Copy link

eclipseo commented May 9, 2019

With Go 1.12.2 on Fedora Rawhide x86_64, commit 6480d4a:

Testing    in: /builddir/build/BUILD/spdystream-6480d4af844c189cf5dd913db24ddd339d3a4f85/_build/src
         PATH: /builddir/build/BUILD/spdystream-6480d4af844c189cf5dd913db24ddd339d3a4f85/_build/bin:/builddir/.local/bin:/builddir/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/spdystream-6480d4af844c189cf5dd913db24ddd339d3a4f85/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/docker/spdystream/version=0 -X github.com/docker/spdystream/version.commit=6480d4af844c189cf5dd913db24ddd339d3a4f85 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/docker/spdystream
github.com/docker/spdystream
--- FAIL: TestSpdyStreams (0.01s)
    spdy_test.go:146: No error closing bad stream
FAIL
exit status 1
FAIL	github.com/docker/spdystream	0.272s

(The test is run in a chroot with no network access.)

I don't see the stream being closed twice in the test to actually trigger the error.

@thaJeztah
Copy link
Member

@dmcgowan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants