Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperkit Build from Release Tarball Fails Assertions Related to Git Version #320

Open
dshick-nydig opened this issue Sep 15, 2021 · 0 comments

Comments

@dshick-nydig
Copy link

dshick-nydig commented Sep 15, 2021

Makefile issue:

hyperkit/Makefile

Lines 1 to 2 in adc4ea8

GIT_VERSION := $(shell git describe --abbrev=6 --dirty --always --tags)
GIT_VERSION_SHA1 := $(shell git rev-parse HEAD)

Release tarballs are not git repositories. This causes failed assertions when connecting with VPNKit.

Assertion failed: (sizeof(VERSION_SHA1) == sizeof(init_msg.commit) + 1), function vpnkit_connect
, file src/lib/pci_virtio_net_vpnkit.c, line 324.

Failed Assertion:

/* msg.commit is not NULL terminated */
assert(sizeof(VERSION_SHA1) == sizeof(init_msg.commit) + 1);
memcpy(&init_msg.commit, VERSION_SHA1, sizeof(init_msg.commit));

This causes problems for the homebrew build of hyperkit: Homebrew/homebrew-core#85232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant