Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RELEASING.md #1236

Open
eminence opened this issue Nov 1, 2022 · 1 comment
Open

Create RELEASING.md #1236

eminence opened this issue Nov 1, 2022 · 1 comment
Labels
Milestone

Comments

@eminence
Copy link
Member

eminence commented Nov 1, 2022

We should have a RELEASING.md document that describes all of the steps needed to prepare and cut a new mosh release. The 1.4.0 release has shown that there were some gaps in our knowledge about how to do this :)

cc @achernya @ezzieyguywuf @bbarenblat

@eminence
Copy link
Member Author

eminence commented Nov 8, 2022

One of the problems with the 1.4.0 release is that we let github automatically create the release (due to creating the 1.4.0 tag), which included a source tarball, but then a few days later, @keithw manually created the "official" source tarball, and re-uploaded it to github, overwriting the old version. This lead to some minor confusion (see #1237 for example, and also some questions in IRC).

We should prevent this in the future. I think the steps we should follow is:

  • git tag the release, and let Github Actions create the source tarball.
  • Github Actions will create a release in "Draft" mode (already done, see here)
  • Someone (Release Manager? Keith?) downloads the tarball and makes sure it looks OK (perhaps by comparing it against a locally generated tarball). If it's OK, then consider the tarball created by Github Actions to be the Official version
  • Remove the "Draft" status from the dig
  • (continue with the rest of the process, like sending out a pgp-signed announcement)

@achernya achernya added this to the mosh-1.5.0 milestone Jan 24, 2023
@achernya achernya added the docs label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants