fix: reinstall ios app to clear state reliably #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how do we make sure this is working? |
herval
approved these changes
Oct 30, 2024
igorsmotto
reviewed
Oct 31, 2024
Comment on lines
+253
to
+255
| launch(deviceId, bundleId, emptyList(), null) | ||
|
|
||
| ensureRunning(deviceId, bundleId) |
There was a problem hiding this comment.
Suggested change
| launch(deviceId, bundleId, emptyList(), null) | |
| ensureRunning(deviceId, bundleId) |
I tested this without launching the app locally, and it works as expected.
Reasoning:
clear state can be used either as a standalone command (- clearState) or as part of the - launchApp command. In the former case, we don't want to launch the app because it's not specified by the command. In the latter case, the app will be launched automatically after clearState, so there's no need to relaunch it.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reinstall the app and then launch it instead of manually trying to delete app state folders, which should improve the experience when relying on clear state to have a completely blank slate in the app.
Relates to #1601