Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E test for iOS #1885

Merged
merged 34 commits into from
Sep 11, 2024
Merged

Add E2E test for iOS #1885

merged 34 commits into from
Sep 11, 2024

Conversation

bartekpacia
Copy link
Contributor

follow up to #1837

@bartekpacia bartekpacia mentioned this pull request Aug 15, 2024
Closed
1 task
@bartekpacia
Copy link
Contributor Author

@amanjeetsingh150 said that he'll fix it by fixing #1585

@bartekpacia bartekpacia mentioned this pull request Sep 10, 2024
Merged
@bartekpacia bartekpacia mentioned this pull request Sep 10, 2024
Merged
@bartekpacia bartekpacia mentioned this pull request Sep 10, 2024
Merged
@bartekpacia bartekpacia mentioned this pull request Sep 11, 2024
Merged
@github-actions GitHub Actions
Copy link

Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change

@bartekpacia
Copy link
Contributor Author

Status: test-ios workflow is still failing and I wasn't able to fix it. That said this PR contains logging improvements I made in the process, and the E2E test of the standalone XCTest Runner. I think it's worth merging it and solving the core problem later.

@bartekpacia bartekpacia merged commit 80f533f into main Sep 11, 2024
6 checks passed
@bartekpacia bartekpacia deleted the test/ios branch September 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartekpacia