Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape support for iOS #565

Closed
johntmcintosh opened this issue Jan 3, 2023 · 31 comments · Fixed by #1809
Closed

Landscape support for iOS #565

johntmcintosh opened this issue Jan 3, 2023 · 31 comments · Fixed by #1809
Assignees
Labels
bug Something isn't working enhancement New feature request or improvement of an existing feature platform: ios Testing iOS apps is affected

Comments

@johntmcintosh
Copy link

iOS testing currently does not support landscape mode. (I am not sure about the current status of landscape support with Android)

As a quick test, download the samples:

maestro download-samples
cd ./samples
unzip sample.zip
xcrun simctl install Booted Wikipedia.app

And update the iOS flow to:

appId: org.wikimedia.wikipedia
---
- launchApp
- tapOn: "Search Wikipedia"
- inputText: "tacos"

Launch the simulator and rotate into landscape mode, and then run:

maestro test ios-flow.yaml

The test reports that it passes, but it does not navigate into the search screen to type into the text.

Running maestro studio shows a mismatch where the overlay content appears to be laid out in landscape, but the image of the app's screen is rotated 90 degrees:

Screen Shot 2023-01-03 at 10 27 16 AM

NOTE: This was discussed in a couple of slack threads, but I'm adding a ticket here so myself and anyone else interested can follow along for status updates or to be notified when support is available.

@mateioprea
Copy link

I have the same issue. I have an app that only runs in landscape mode on iPad and maestro mismatches all the elements. If I test with portrait orientation, everything works.

@kdsanchezv
Copy link

Hey guys, somebody knows if there is any progress regarding this issue?
That's the only blocker we have to use maestro in our tests.

@Guyentie
Copy link

I'm having the same issue for an Ipad app that is mainly used in landscape mode.

@Plimsky
Copy link

Plimsky commented Mar 20, 2023

Hi there! 👋
I'm having the same issue with my project in which it's specifically designed in landscape mode. Is there any update or ongoing investigations about this?
Thanks for the update! 👍

@axelniklasson axelniklasson added the enhancement New feature request or improvement of an existing feature label May 3, 2023
@ArthurSav
Copy link
Contributor

Hi, this is something we'd like to add but we can't provide an ETA yet. We'll update this thread with news.

@WenzhaoTan-Chowbus
Copy link

I have the same issue with an Ipad app mainly used in landscape mode.

@meboev-fourth
Copy link

What is the status with this? It should be set with a high priority.
That's not an enhancement, it's a really nasty defect. It's been 6 months already, and no one has done anything about it.

@mdethlefs
Copy link

same issue. we have a video player we can toggle to fullscreen and all the elements are mismatched in maestro studio

@ccfiel
Copy link

ccfiel commented Jul 15, 2023

Still no updates? Is there any roadmap of the project?

@ccfiel
Copy link

ccfiel commented Jul 18, 2023

This is fine in android but in iOS was not fine, it will just complete the steps but not executed in the emulator. See video. @ArthurSav

Untitled_.Jul.18.2023.3_36.PM.webm

@mdethlefs
Copy link

any updates?
we have a video player in our app and we basically can't test anything in fullscreen mode because of this. both iOS and Android.

@ericledonge
Copy link

I have issue with Android tablet in Maestro Cloud (everything is fine in local).

@raymond-tetteh
Copy link

I have the same issue. When is this going to be worked on?

@dinisnunes1
Copy link

dinisnunes1 commented Dec 14, 2023

Is there any news on this feature? It's really preventing us to use Maestro for our UI tests.

@davemess
Copy link

+1

@chiefchief
Copy link

have the same issue on iPad in landscape orientation, any updates?

@barbaramartina
Copy link

Hello, when do you think that landscape support will be in your pipeline? With the new European Legal Regulations on Accessibility, applications will need to support landscape by June 2025. It would be great to be able to test in landscape at least a couple of month before. Thanks

@bartekpacia
Copy link
Contributor

bartekpacia commented Jul 10, 2024

@barbaramartina Thanks for this interesting insight. We are aware this problem is important for you; it's in our backlog.

For tracking purposes: there's a related issue #1679

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.
Thank you for helping keep us our issue tracker clean!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
@bartekpacia
Copy link
Contributor

re-opening as this had to be reverted in v1.37.9

@bartekpacia bartekpacia reopened this Aug 20, 2024
@mobile-dev-inc mobile-dev-inc unlocked this conversation Aug 20, 2024
@tkhvaira
Copy link

good day, any movement with this issue, really looking forward to this fix

@bartekpacia
Copy link
Contributor

This is already fixed on our main branch. See PRs #1974 and #2050.

@bartekpacia
Copy link
Contributor

We'll release this soon as part of Maestro version 1.39.

@barbaramartina
Copy link

Thanks. When is the version going to be released?

@bartekpacia
Copy link
Contributor

Either tomorrow or next week.

@klyovan
Copy link

klyovan commented Sep 12, 2024

Either tomorrow or next week.

Hi Bartek, just checked your unreleased version (CLI 1.39.0-dev.1) and now the landscape works fine, but the native popups are not displaying correctly and it is also not possible to click on them with Maestro, could you please check this case ?
Screenshot 2024-09-12 at 21 34 53
Tested on simulator: Ipad Pro 11-inch (M4)
This popup is called by native code but invoked from Flutter using platform channel
If I try to debug it using maestro studio, I can see that the nodes for cancel and continue item exists on the screen, but they are flattened and positioned to the left and below, but still not clickable using either the studio or the yaml file.

@bartekpacia
Copy link
Contributor

The currently available draft version doens't reflect the latest master. Let me relase a new one in a few minutes.

@bartekpacia
Copy link
Contributor

bartekpacia commented Sep 12, 2024

Please check out v1.39.0-dev.2:

# before doing this, uninstall all existing maestro versions
brew update
brew install [email protected]

@klyovan
Copy link

klyovan commented Sep 13, 2024

The issue with native popup still there
Screenshot 2024-09-13 at 08 21 20

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.
Thank you for helping keep us our issue tracker clean!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
@bartekpacia
Copy link
Contributor

@klyovan Please create a new issue (and reference this one)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature request or improvement of an existing feature platform: ios Testing iOS apps is affected
Projects
None yet
Development

Successfully merging a pull request may close this issue.