Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout not working in scrollUntilVisible #2108

Open
1 task done
alecalma opened this issue Oct 22, 2024 · 2 comments · May be fixed by #2112
Open
1 task done

Timeout not working in scrollUntilVisible #2108

alecalma opened this issue Oct 22, 2024 · 2 comments · May be fixed by #2112

Comments

@alecalma
Copy link

alecalma commented Oct 22, 2024 •
edited by Fishbowler
Loading

Is there an existing issue for this?

  • I have searched the existing issues and didn't find mine.

Steps to reproduce

- launchApp:
    clearState: true
- swipe:  
    direction: DOWN
- assertVisible:
    text: "Login"
    enabled: true
- tapOn:
    text: "Login"
- scrollUntilVisible:
    element:
        text: XYZ
    direction: DOWN 
    timeout: 1000

Actual results

As easy as it sounds, the timeout parameter does not work for the method scrollUntilVisible, Maestro keeps scrolling forever.

Expected results

I expect the test to fail after the timeout duration.

About app

Native app for android mobile in ReactNative.

About environment

Pixel 9 Pro API35 from AndroidStudio.

Logs

No response

Maestro version

1.39.0

How did you install Maestro?

Homebrew

Anything else?

No response
@linear Linear
Copy link

linear bot commented Oct 22, 2024

MA-2386 Timeout not working in scrollUntilVisible

vibin added a commit to vibin/maestro that referenced this issue Oct 23, 2024
@vibin
Fix timeout unit in ScrollUntilVisibleCommand
19404ff 
The `timeout` in ScrollUntilVisibleCommand should be interpreted as milliseconds: https://maestro.mobile.dev/api-reference/commands/scrolluntilvisible

Fixes mobile-dev-inc#2108.
This was broken by mobile-dev-inc#2023.
@vibin vibin linked a pull request Oct 23, 2024 that will close this issue
Open
@vibin
Copy link

vibin commented Oct 23, 2024

@bartekpacia fixed this in #2112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix timeout unit in ScrollUntilVisibleCommand vibin/maestro
2 participants
@vibin @alecalma