Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direction parameter to scroll command #1753

Closed
LinusMuema opened this issue May 22, 2024 · 6 comments
Closed

Add direction parameter to scroll command #1753

LinusMuema opened this issue May 22, 2024 · 6 comments
Labels
enhancement New feature request or improvement of an existing feature good first issue Good for newcomers wanting to contribute maestro cli Related to the command-line Maestro tool waiting for customer response More information is needed from the customer before we can progress on the issue

Comments

@LinusMuema
Copy link

Is your feature request related to a problem? Please describe.
In our application some, we have a dynamic topbar that disappears on scrolling upwards but appears again on any downwards scroll. Just like CoordinatorLayout.

Describe the solution you'd like
It would be really great if we had options in the scroll command to specify the direction of the secoll and maybe orientation to support both horizontal and vertical scroll.

Describe alternatives you've considered
N/A

Additional context

@LinusMuema LinusMuema added the enhancement New feature request or improvement of an existing feature label May 22, 2024
@bartekpacia
Copy link
Contributor

bartekpacia commented Jul 11, 2024

Hi @LinusMuema 👋 thanks for creating the issue

The request here is to have the scroll command accept more parameters, similarly to what scrollUntilVisible has, right?

@bartekpacia bartekpacia added the maestro cli Related to the command-line Maestro tool label Jul 11, 2024
@LinusMuema
Copy link
Author

Hi @bartekpacia

Yes exactly. To specify the direction of scrolling.

@bartekpacia
Copy link
Contributor

Understood. We're a small team that's very busy, but we'll do our best to get this done in the future.

Since this feature is already implemented for scrollUntilVisible, I'm also gonna add good first issue label and hope some good soul shows up!

@bartekpacia bartekpacia added the good first issue Good for newcomers wanting to contribute label Jul 12, 2024
@bartekpacia bartekpacia changed the title [Feature Request] Bi-directional vertical scroll Add direction parameter to scroll command Jul 12, 2024
@bartekpacia
Copy link
Contributor

There's already swipe command which seems to have what you're asking for. Does that resolve your issue?

@bartekpacia bartekpacia added the waiting for customer response More information is needed from the customer before we can progress on the issue label Jul 14, 2024
Copy link

Without additional information, we can't resolve this issue. We're therefore reluctantly going to close it.
Feel free to open a new issue with all the required information provided, including a [minimal, reproducible sample]. When creating a new issue, please make sure to diligently fill out the issue template.
Thank you for your contribution to our open-source community!
[minimal, reproducible sample]: https://stackoverflow.com/help/minimal-reproducible-example

Copy link

github-actions bot commented Aug 5, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.
Thank you for helping keep us our issue tracker clean!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature request or improvement of an existing feature good first issue Good for newcomers wanting to contribute maestro cli Related to the command-line Maestro tool waiting for customer response More information is needed from the customer before we can progress on the issue
Projects
None yet
Development

No branches or pull requests

2 participants