Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Detecting Maestro in your app" docs to reflect port change #95

Open
joepatosh opened this issue Oct 9, 2024 · 0 comments
Open

Comments

@joepatosh
Copy link

joepatosh commented Oct 9, 2024

The docs for Detect Maestro in your app state that iOS uses port 22087

This is no longer true in recent versions of maestro. By default, maestro uses port 7001 as discussed here

If this change was intended, could the docs please be updated to reflect it?

I'm opening an issue rather than a simple PR to change "22087" to "7001" because it seems the reality is more complicated and nuanced than that. As discussed here, the new sharding execution logic means maestro could be running on any port in the range of (7001..7128). Given that complication, it is not clear to me how the docs should be updated to account for this.

I'd be happy to open a PR with my best attempt at updating the docs to reflect the current situation. But I wanted to open this issue first because perhaps the maintainers have some context or understanding that I am lacking.

Please let me know if you'd like me to submit a PR for this change!

Or if there is some nuance or context you can share to clarify the situation, that would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant