Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enhance the go-date-picker by enabling the calendar to open when the date field is clicked anywhere within it. #918

Open
sinchananj12 opened this issue Jun 13, 2023 · 0 comments
Open

[Feature] Enhance the go-date-picker by enabling the calendar to open when the date field is clicked anywhere within it. #918

sinchananj12 opened this issue Jun 13, 2023 · 0 comments
Labels
feature New feature request new issue This issue has yet to receive attention

Comments

@sinchananj12
Copy link
Contributor

sinchananj12 commented Jun 13, 2023 •
edited
Loading

Description
Need a functionality where the calendar opens upon clicking anywhere within the date field of go-date-picker, rather than being restricted to only clicking on the calendar icon. This enhancement will significantly enhance the user experience, providing a more intuitive and seamless process for selecting dates.

Solution
The feature should satisfy the following requirements:

  1. A click event must be activated when the user clicks anywhere within the date field, resulting in the opening of the calendar.
  2. An input event should be incorporated to automatically close the calendar if it is already open, when the user starts to enter date manually.
@sinchananj12 sinchananj12 added feature New feature request new issue This issue has yet to receive attention labels Jun 13, 2023
sinchananj12 added a commit that referenced this issue Jul 12, 2023
@sinchananj12
#918 datepicker enhancement
c55fe9f
sinchananj12 added a commit that referenced this issue Jul 12, 2023
@sinchananj12
#918 enhancement of go-date-picker
356fdf5
sinchananj12 added a commit that referenced this issue Jul 18, 2023
@sinchananj12
#918 - enhance go-date-picker
80ec883
sinchananj12 added a commit that referenced this issue Sep 21, 2023
@sinchananj12
#918 - Added test cases
ac7dbb8
sudheepdivakargithub added a commit that referenced this issue Sep 22, 2023
@sudheepdivakargithub
Merge pull request #921 from mobi/918-Enhance_go-date-picker_by_enabl…
299f5f4 
…ing_calendar_to_open_when_date_field_is_clicked_anywhere_within_it

[Feature] #918 enhancement of go-date-picker
swimtech20 added a commit that referenced this issue Jan 5, 2024
@swimtech20 @sudheepdivakargithub
@adhiyan-tangoe @Saravanan-Tangoe @Pooja-kj @Vijeta7 @RonMichaud @vishal-tangoe @sinchananj12 @ankit-tangoe
Goponents release v1.16.1 (#933)
121e121 
* Update go-button.component.scss

Changes for split button option text not to wrap and grow towards left.

* GOP-877-BUG-minimum_height_for_textarea

Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.

* Changes_bugfix_chore_task

* alignment corrected for icon button

css changes for button padding

* codeclimate issue fix

* Codeclimate fix

* remove extra padding

* Initial components and module interaction

* Accordion_style changes

Accordion styles
Default
Slim
Dark

* Changed dark theme

* Changes [CHORE] 868 max height for toast

Max height for the toast notification will not have an overflow unless specified.

* Changes [CHORE] 767 action sheet design changes #767

1. Handled appearance of scrollbar on accordion's expansion by adjusting the height.
2. Font style changes for the shell area.
3. Fixed the colour issue for the danger action sheet.

* Update _forms.scss

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* Determinate and indeterminate progress bar

* style update

* Changes [CHORE] 868 max height for toast #890

1. Code review suggested changes.
2. Change in the code's header part in the documentation.

* UT

* safari styling fix

* Fixing code climate issues

* Changes [CHORE] 868 max height for toast #890

Code review suggested changes.

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* comment line message

* clear code climate issues

* code climate fix

* dark theme color changes done

* issue fixed

* removed white spaces

* BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE

* ALIGNMENT AND NAMING CHANGES

* Fix for duplicate modal and offcanvas content

* ALIGNMENT_CHANGES

* removing whitespace

* Re-run Checks

* Re-run Checks

* Increasing test coverage

* Update github src

* GOP-807 empty checkin to trigger build

* Fix select all filtered list (#914)

* bug fixes for select all filtered list

* single item, add remove handled

* handling controls initial value incase of typeahead provided

* changes in handling controls initial value

* small condition fix

* test cases updated and condition change in init control value

* formatting changes

* formatting changes

* edge case handled while removing selected item

* formatting changes

* adding count to select all

* adding count to select all

* linting errors fixed

* typo fixed

* refactored code for better understanding

* refactoring

* lint fix

* indentation changes, private methods and variables grouped, minor ux changes

* renaming methods

* karma config thresold changes

---------

Co-authored-by: Vishal Shah <[email protected]>

* v1.16.0 (#915)

* Incrementing minor version

Changes were made to upgrade "select all filter list"

* Fixing patch version to be 0

Forgot to do this before...

* #918 enhancement of go-date-picker

* #918 - enhance go-date-picker

* Added inout property to control the visibility of go-form-error.
Implemented in all controls with go-form-error.

* updated the documentation.

* Rearranged the property

* Used single quote instead of double quotes.

* Added few more tests

* #918 -  Added test cases

* Added app-drawer stylings

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Update CSS for Drodown and add test cases

* add few test cases based on background color

* Add some more test cases for disable color

* Resolve build issue and update test cases

* Resolve code coverage issue and add few more test cases

* Update test cases for enable and disable color for dropdown

* Updating version number to reflect recent changes

---------

Co-authored-by: sudheepdivakargithub <[email protected]>
Co-authored-by: adhiyan-tangoe <[email protected]>
Co-authored-by: Saravanan Muralidharan <[email protected]>
Co-authored-by: Pooja-kj <[email protected]>
Co-authored-by: Vijeta7 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: RonMichaud <[email protected]>
Co-authored-by: Vishal Shah <[email protected]>
Co-authored-by: Sinchana <[email protected]>
Co-authored-by: CORP\Sudheep.Divakar <[email protected]>
Co-authored-by: Amit Patra <[email protected]>
Co-authored-by: ankit-tangoe <[email protected]>
swimtech20 added a commit that referenced this issue Mar 19, 2024
@swimtech20 @sudheepdivakargithub
@adhiyan-tangoe @Saravanan-Tangoe @Pooja-kj @Vijeta7 @RonMichaud @vishal-tangoe @sinchananj12 @ankit-tangoe @preetigairi
Goponent Release 1.17.0 - Increasing minor version (in case of regres…
2ce0e2b 
…sion and easier history tracking) (#940)

* Update go-button.component.scss

Changes for split button option text not to wrap and grow towards left.

* GOP-877-BUG-minimum_height_for_textarea

Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.

* Changes_bugfix_chore_task

* alignment corrected for icon button

css changes for button padding

* codeclimate issue fix

* Codeclimate fix

* remove extra padding

* Initial components and module interaction

* Accordion_style changes

Accordion styles
Default
Slim
Dark

* Changed dark theme

* Changes [CHORE] 868 max height for toast

Max height for the toast notification will not have an overflow unless specified.

* Changes [CHORE] 767 action sheet design changes #767

1. Handled appearance of scrollbar on accordion's expansion by adjusting the height.
2. Font style changes for the shell area.
3. Fixed the colour issue for the danger action sheet.

* Update _forms.scss

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* Determinate and indeterminate progress bar

* style update

* Changes [CHORE] 868 max height for toast #890

1. Code review suggested changes.
2. Change in the code's header part in the documentation.

* UT

* safari styling fix

* Fixing code climate issues

* Changes [CHORE] 868 max height for toast #890

Code review suggested changes.

* Changes [CHORE] 767 action sheet design changes #891

Code review suggestion changes

* comment line message

* clear code climate issues

* code climate fix

* dark theme color changes done

* issue fixed

* removed white spaces

* BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE

* ALIGNMENT AND NAMING CHANGES

* Fix for duplicate modal and offcanvas content

* ALIGNMENT_CHANGES

* removing whitespace

* Re-run Checks

* Re-run Checks

* Increasing test coverage

* Update github src

* GOP-807 empty checkin to trigger build

* Fix select all filtered list (#914)

* bug fixes for select all filtered list

* single item, add remove handled

* handling controls initial value incase of typeahead provided

* changes in handling controls initial value

* small condition fix

* test cases updated and condition change in init control value

* formatting changes

* formatting changes

* edge case handled while removing selected item

* formatting changes

* adding count to select all

* adding count to select all

* linting errors fixed

* typo fixed

* refactored code for better understanding

* refactoring

* lint fix

* indentation changes, private methods and variables grouped, minor ux changes

* renaming methods

* karma config thresold changes

---------

Co-authored-by: Vishal Shah <[email protected]>

* v1.16.0 (#915)

* Incrementing minor version

Changes were made to upgrade "select all filter list"

* Fixing patch version to be 0

Forgot to do this before...

* #918 enhancement of go-date-picker

* #918 - enhance go-date-picker

* Added inout property to control the visibility of go-form-error.
Implemented in all controls with go-form-error.

* updated the documentation.

* Rearranged the property

* Used single quote instead of double quotes.

* Added few more tests

* #918 -  Added test cases

* Added app-drawer stylings

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Fixed code climate lint errors.

* Update CSS for Drodown and add test cases

* add few test cases based on background color

* Add some more test cases for disable color

* Resolve build issue and update test cases

* Resolve code coverage issue and add few more test cases

* Update test cases for enable and disable color for dropdown

* Updating version number to reflect recent changes

* Selecting date as 29 Feb for any of the date fields is throwing error across the modules (#936)

* FEB_29th_selection

* #GOCLD 2298 test cases

* #GOCLD 2298 test cases

* #GOCLD 2298 test cases

* Update Goponent version (#937)

Includes Leap Day calculations fix.

* Update minor version for release (#939)

* Update to major version release

For easier history tracking/bug fixing. Noticed there were several file changes (1 commit) in main but not in dev... thoughts are this is related to the Activity Manager feature Persistent worked on in 2022-2023.

* Making this a minor version update and not major

Discussed with Jiawei

---------

Co-authored-by: sudheepdivakargithub <[email protected]>
Co-authored-by: adhiyan-tangoe <[email protected]>
Co-authored-by: Saravanan Muralidharan <[email protected]>
Co-authored-by: Pooja-kj <[email protected]>
Co-authored-by: Vijeta7 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: RonMichaud <[email protected]>
Co-authored-by: Vishal Shah <[email protected]>
Co-authored-by: Sinchana <[email protected]>
Co-authored-by: CORP\Sudheep.Divakar <[email protected]>
Co-authored-by: Amit Patra <[email protected]>
Co-authored-by: ankit-tangoe <[email protected]>
Co-authored-by: preetigairi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature request new issue This issue has yet to receive attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sinchananj12