[fix] edf.py: potential overflow with n_events=256 #12859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the n_events assigned with the UINT8 type of number "ne". So, the default type of n_events will also be UINT8. During the summation of all three byte of "ne" will potentially cause overflow. In my case, python raised overflow error when it reach 256 which exceed the upper limit of 255. Direct Bit-Wise operation can avoid this.
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
larsoner
reviewed
Sep 19, 2024
Comment on lines
1442
to
+1443
| ne = np.fromfile(fid, UINT8, 3) | ||
| n_events = ne[0] | ||
| for i in range(1, len(ne)): | ||
| n_events = n_events + ne[i] * 2 ** (i * 8) | ||
| n_events = ne[0] + (ne[1] << 8) + (ne[2] << 16) |
There was a problem hiding this comment.
I think this is a fix on NumPy < 2 but on 2.1 I get:
>>> np.uint8(255) + np.uint8(255)
<stdin>:1: RuntimeWarning: overflow encountered in scalar add
np.uint8(254)
So I think maybe doing this would be a clean way to fix it
ne = np.fromfile(fid, UINT8, 3).astype(np.int64)
or similar
|
I think this was fixed by #12909 in the meantime, but happy to see other PRs in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the n_events assigned with the UINT8 type of number "ne". So, the default type of n_events will also be UINT8. During the summation of all three byte of "ne" will potentially cause overflow. In my case, python raised overflow error when it reach 256 which exceed the upper limit of 255. Direct Bit-Wise operation can avoid this.
Reference issue (if any)
What does this implement/fix?
Additional information