Example to extract time courses with labels from custom atlas #12618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Looks great, thank 😄 ping me when you want a review, a couple of small points for now:
- Title should have as many
=under and above as characters in the title - You can check the rendered docs in the
Check the render docsworkflow, for now here. - Prefer
pathlib.Pathoveros.path.join()to handle file/folder paths - Add a changelog entry by adding a file to this folder.
- This is raised at the moment:
FileNotFoundError: MRI image does not exist: "/home/circleci/mne_data/MNE-sample-data/subjects/sample/mri/yeo_atlasaseg.mgz"
… file existence to diagnose error, correct number of = around title
for more information, see https://pre-commit.ci
Replaces all os.path calls with posix Path Replaces all os.system calls with subprocess.run to fail on command failure.
for more information, see https://pre-commit.ci
…nto source_atlas_branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
An example on how to extract time courses of source reconstructed data when using a custom parcellation atlas!
On suggestion by @mscheltienne
Additional information
None, really.