Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic groups much faster than molecular group #260

Open
2 tasks
mlund opened this issue Feb 28, 2020 · 1 comment
Open
2 tasks

Atomic groups much faster than molecular group #260

mlund opened this issue Feb 28, 2020 · 1 comment

Comments

@mlund
Copy link
Owner

mlund commented Feb 28, 2020

Salt particles can be treated either as atomic or molecular groups. For a speciation system with equal number of particles with and without nonbonded interactions:

group ideal nonbonded
atomic=true 0.4s 4.0s
atomic=false 12s 20s

Run using proposed code in #259 with this input:
input.zip

Things to check:

  • Benchmark for bottlenecks
  • It is likely that the difference is in Space::findMolecules() for locating active/inactive particle. For atomic the call is more or less independent of N since the atomic group is ordered with active then inactive particles. For molecules, the operation scales with N. A Space particle tracker would solve this and was implemented in earlier Faunus versions.

ping @rc83

Update: Removing the sanity analysis reduces the molecular time by a factor of six (ideal) or two (nonbonded). Atomic is still significantly faster.

@mlund
Copy link
Owner Author

mlund commented Nov 15, 2021

ping @Smutekj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant