serde_userdata
: Remove map_err
to reduce compile time impact
#441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map_err
has a disproportionate impact on the LLVM IR generated. In generic functions it's beneficial for compile times to avoid it. This reduces the LLVM lines of a crate that heavily uses mlua from 2420270 to 2302295. It could be reduced by a further 50000 lines by manually inliningserde_userdata
, but as that would make the code a bit less readable I'm holding off on that.