-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Dark Mode bug #393
Comments
The site is staticly generated to be light mode. Meaning the HTML is precompiled. On load the page renders all the html and styling and then injects javascript. That javascript then looks at your local storage for a value and adjusts the site based on that value. However there is a fairly hacky workaround that could work: https://joshwcomeau.com/gatsby/dark-mode and https://github.com/joshwcomeau/dark-mode-minimal Though it feels like a few hours of work that I don't want to particularly fix at this time for an edge case that only occurs on a full hard refresh. |
It also happens when you update a page. What I find strange is that the background changes but not the font color. But anyway, I also agree this is low priority. |
When I update a page, or when you refresh? Updating a page would be expected as then the cache is cleared. On refresh doesn't seem to happen for m, likely due to some of the offline work I put in. |
When you update. I know it's expected, I was just clarifying. |
I believe this is solved |
Not fixed it appears to be ok on mobile where you can't hard refresh, but desktop hard refresh is still broken. It's much less of an issue now (only that first load), but still an issue |
Steps to reproduce:
The page will swap to light mode for a moment before loading the black background, but the headers' colors won't change.
The text was updated successfully, but these errors were encountered: