Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes & improvements in tutorials #517

Merged
merged 27 commits into from
Jan 9, 2024

Conversation

VukW
Copy link
Contributor

@VukW VukW commented Dec 21, 2023

Data tutorial: removed predefined dataset hash as it varies depending on environment

@VukW VukW requested a review from a team as a code owner December 21, 2023 15:27
@VukW VukW had a problem deploying to testing-external-code December 21, 2023 15:27 — with GitHub Actions Failure
Copy link
Contributor

github-actions bot commented Dec 21, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

If user starts with any of tutorials, he is advised to install server (`setup.md`) but no word about client installation
@VukW VukW had a problem deploying to testing-external-code December 25, 2023 16:06 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code December 27, 2023 18:55 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code December 30, 2023 00:18 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 1, 2024 15:38 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 1, 2024 18:08 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 2, 2024 17:17 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 3, 2024 11:15 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 3, 2024 11:16 — with GitHub Actions Failure
- profiles.md
- associations.md
- priorities.md
- single_run.md
- cli_reference.md
new DataPrep and Metrics docs have to be aligned with Model doc: the goal of guide is to help user wrap their existing code into cube
@VukW VukW had a problem deploying to testing-external-code January 5, 2024 14:18 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 9, 2024 10:44 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 9, 2024 10:45 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 9, 2024 10:46 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 9, 2024 10:48 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 9, 2024 10:49 — with GitHub Actions Failure
@VukW VukW temporarily deployed to testing-external-code January 9, 2024 10:50 — with GitHub Actions Inactive
@hasan7n hasan7n self-requested a review January 9, 2024 10:53
Copy link
Contributor

@hasan7n hasan7n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man! Awesome work!

@VukW VukW merged commit c1f809a into mlcommons:main Jan 9, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
@VukW VukW deleted the tutorials-improvement branch February 1, 2024 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The relevance of downloaded files for tutorials is not clear
2 participants