Use filesystem for storing auth tokens #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
hasan7n
temporarily deployed
to
testing-external-code
GitHub Actions
Inactive
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using
keyringto store access and refresh tokens. We expect that the MedPerf client will be used on remote machines that could be accessed by passwordless methods such as SSH keys. This will prevent unlocking the system keychain on remote machines and hencekeyringwill not work in a straightforward way. This PR replaces theTokenStoreclass that implementskeyringwith a class that implements filesystem storage.Note: We could easily rollback to using
keyringif we find a solution in the future.closes #508