Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update #473

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Doc update #473

merged 1 commit into from
Aug 3, 2023

Conversation

vpchung
Copy link
Contributor

@vpchung vpchung commented Aug 3, 2023

Changelog

  • Update docs: medperf synapse_loginmedperf auth synapse_login

@vpchung vpchung requested a review from a team as a code owner August 3, 2023 08:10
@vpchung vpchung had a problem deploying to testing-external-code August 3, 2023 08:10 — with GitHub Actions Failure
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@vpchung
Copy link
Contributor Author

vpchung commented Aug 3, 2023

Note: the Synapse Python Client has plans to deprecate non-auth token logins (e.g. username + password) as well as the rememberMe parameter by early 2024. I can file a follow-up ticket to update this script?

Copy link
Contributor

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasan7n
Copy link
Contributor

hasan7n commented Aug 3, 2023

@vpchung thanks for spotting this!
Regarding the deprecation of username-password auth, that sounds good! We can have a ticket to track this.

@hasan7n hasan7n merged commit b9b4d68 into mlcommons:main Aug 3, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants