Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Read-only inputs are not as supposed to be #489

Closed
hasan7n opened this issue Sep 18, 2023 · 1 comment
Closed

[BUG] Read-only inputs are not as supposed to be #489

hasan7n opened this issue Sep 18, 2023 · 1 comment
Labels
High Priority Urgent tasks type: bug Something isn't working

Comments

@hasan7n
Copy link
Contributor

hasan7n commented Sep 18, 2023

There is a typo in the passed MLCube parameters that make input folders and files read-only:
We use e.g.:
Ptasks.evaluate.parameters.input.predictions.opts

but it should be:

-Ptasks.evaluate.parameters.inputs.predictions.opts

(There was a missing dash - and a missing s in inputs)

Currently, MLCube ignores the parameters (because there is a typo) and hence doesn't enforce the inputs to be read-only.
Also, it's may be good to have an integration test for such scenario.

@hasan7n hasan7n added type: bug Something isn't working High Priority Urgent tasks labels Sep 18, 2023
@hasan7n
Copy link
Contributor Author

hasan7n commented Sep 18, 2023

tracked in #488

@hasan7n hasan7n closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Urgent tasks type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant