CompatHelper: bump compat for OptimizationOptimJL to 0.2, (keep existing compat) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2024-01-06-00-14-59-543-04204179526
branch
from
b30ff14
to
f165fa2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 92.92% 93.10% +0.17%
==========================================
Files 13 13
Lines 594 609 +15
==========================================
+ Hits 552 567 +15
Misses 42 42 ☔ View full report in Codecov by Sentry. |
|
There are some breaking changes to the callback arguments we need to adjust for, see SciML/Optimization.jl#652 (comment) |
|
It seems to support OptimizationOptimJL, we would need Optimization v3.21.0, which would require us to drop support for Julia v1.6-v1.8, see SciML/Optimization.jl#639 |
|
By conditioning on the existence of |
Now that v1.10 is released, this is redundant.
sethaxen
deleted the
compathelper/new_version/2024-01-06-00-14-59-543-04204179526
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
OptimizationOptimJLpackage from0.1to0.1, 0.2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.