From ebdc1bc79bc67775cddd560fd7afaaa0adf1d6d5 Mon Sep 17 00:00:00 2001 From: Mickael Labarrere <35226465+mlabarrere@users.noreply.github.com> Date: Sat, 26 Dec 2020 12:49:54 +0100 Subject: [PATCH] Fix PyLint + Flakes8 --- pygquery/{BigQueryReader.py => bigquery_reader.py} | 11 ++++++++++- pygquery/{BigQueryWriter.py => bigquery_writer.py} | 12 ++++++++---- 2 files changed, 18 insertions(+), 5 deletions(-) rename pygquery/{BigQueryReader.py => bigquery_reader.py} (89%) rename pygquery/{BigQueryWriter.py => bigquery_writer.py} (90%) diff --git a/pygquery/BigQueryReader.py b/pygquery/bigquery_reader.py similarity index 89% rename from pygquery/BigQueryReader.py rename to pygquery/bigquery_reader.py index 42f5f0c..868f51f 100644 --- a/pygquery/BigQueryReader.py +++ b/pygquery/bigquery_reader.py @@ -1,8 +1,16 @@ +"""BigQueryReader +Reads a query +""" + from threading import Thread from google.cloud import bigquery from google.oauth2.service_account import Credentials + class BigQueryReader(Thread): + """BigQueryReader + Reads a query + """ def __init__(self, request, project, api_key_path): """Object Configuration""" Thread.__init__(self) @@ -27,9 +35,10 @@ def __init__(self, request, project, api_key_path): raise RuntimeError(self._query_job.errors) def run(self): - + """Start thread""" self._data = self._query_job.to_dataframe() @property def data(self): + """return data""" return self._data diff --git a/pygquery/BigQueryWriter.py b/pygquery/bigquery_writer.py similarity index 90% rename from pygquery/BigQueryWriter.py rename to pygquery/bigquery_writer.py index 13195cf..deff690 100644 --- a/pygquery/BigQueryWriter.py +++ b/pygquery/bigquery_writer.py @@ -1,15 +1,19 @@ +"""BigQueryWriter +Writes a query +""" + from threading import Thread from google.cloud import bigquery from google.oauth2.service_account import Credentials -lass BigQueryWriter(Thread): + +class BigQueryWriter(Thread): + """Reads Query""" def __init__(self, dataframe, project, dataset, table, if_exists, api_key_path): """Object Configuration""" Thread.__init__(self) - """Client Configuration""" credentials = Credentials.from_service_account_file(api_key_path) - _client = bigquery.Client(credentials=credentials, project=project) dataset_ref = _client.dataset(dataset) @@ -32,5 +36,5 @@ def __init__(self, dataframe, project, dataset, table, if_exists, job_config=_job_config) def run(self): - + """starts writing data""" self._query_job.result()