Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use with ocaml 5 #21

Closed
joprice opened this issue Aug 5, 2023 · 4 comments
Closed

use with ocaml 5 #21

joprice opened this issue Aug 5, 2023 · 4 comments

Comments

@joprice
Copy link
Collaborator

joprice commented Aug 5, 2023

What would it take to build the project on ocaml 5? I tried building from nix with an ocaml 5 overlay and ended up with a ppxlib error:

File "packages/intf_of_sign/intf_of_sign.ml", line 85, characters 4-26:
85 |     of_type_desc type_desc
         ^^^^^^^^^^^^^^^^^^^^^^
Error: This expression has type
         Ppxlib_ast.Ast.expression = Astlib__Ast_414.Parsetree.expression
       but an expression was expected of type Parsetree.expression

There is a constraint on < ocaml 5, so I assume there's some compatibility issues that need to be resolved first?

@davesnx
Copy link
Member

davesnx commented Aug 11, 2023

Hey @joprice, currently it's mean to be used with 4.14 just because the version of ppxlib (0.23) isn't available for OCaml 5.

There's another inconvenience for OCaml 5, which isn't a blocker per se but I'm using Lwt which isn't the greatest with 5 ocsigen/lwt#897, probably can fix it by using https://github.com/talex5/lwt_eio but still I would rather update to use eio/OCaml 5 in one go.

Regardles, I will keep the issue open.

@davesnx
Copy link
Member

davesnx commented Aug 25, 2023

Hey @joprice, made a PR where I have building with opam and OCaml 5.1.0-rc1 and will merge soon.

@davesnx
Copy link
Member

davesnx commented Aug 25, 2023

Merged, updated the CI to run with 5.0 (as well as 4.14). Let me know if it works with Nix so I can close this issue!

@davesnx davesnx closed this as completed Sep 6, 2023
@joprice
Copy link
Collaborator Author

joprice commented Sep 11, 2023

@davesnx thanks! I’ve been on vacation but will try it out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants