You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see that Condition has convenience methods for specific HTTP methods, such as Condition.get(String uri). That's fine if I want to specify an exact path. But what if I want to use that in conjunction with Condition.matchesUri(Pattern p)? Why isn't there a Condition.get() method I can use like this?
Why can't I just use get() by itself, to combine it with any matcher I want?
You might say I could just use Condition.method(Method m), but as explained in #22 that forces me to use the Glassfish API --- and there's no need for that. If there is a Condition.get() method at all, why is it tied to a URI, when I could simply say matches(get(), uri("foo")) to do the same thing as matches(get("foo"))?
Yes, I understand that get(String uri) is a convenience method, but convenience methods should allow the long, more flexible form as well. Put another way, it is more flexible to allow matches(get(), uri("foo")), and provide matches(get("foo")) as an additional convenience. Only providing the latter without the former makes the API less flexible.
The text was updated successfully, but these errors were encountered:
It's possible that I could have a developer available to address some of these issues (e.g. #65 and the others we've been discussing) in about a month or two; if so, I would be happy to contribute!
I see that
Condition
has convenience methods for specific HTTP methods, such asCondition.get(String uri)
. That's fine if I want to specify an exact path. But what if I want to use that in conjunction withCondition.matchesUri(Pattern p)
? Why isn't there aCondition.get()
method I can use like this?Why can't I just use
get()
by itself, to combine it with any matcher I want?You might say I could just use
Condition.method(Method m)
, but as explained in #22 that forces me to use the Glassfish API --- and there's no need for that. If there is aCondition.get()
method at all, why is it tied to a URI, when I could simply saymatches(get(), uri("foo"))
to do the same thing asmatches(get("foo"))
?Yes, I understand that
get(String uri)
is a convenience method, but convenience methods should allow the long, more flexible form as well. Put another way, it is more flexible to allowmatches(get(), uri("foo"))
, and providematches(get("foo"))
as an additional convenience. Only providing the latter without the former makes the API less flexible.The text was updated successfully, but these errors were encountered: