Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No semantic parsing or deduplication #28

Open
jhoffmanmixmax opened this issue Aug 24, 2019 · 0 comments
Open

No semantic parsing or deduplication #28

jhoffmanmixmax opened this issue Aug 24, 2019 · 0 comments

Comments

@jhoffmanmixmax
Copy link

jhoffmanmixmax commented Aug 24, 2019

Currently, the library allows for things like cheese and -cheese to be inputted, and doesn't reason about the semantic meaning of having a property and its negation both present. There's also no duplicate checking.

If we were to add duplicate checking, would we want to perform that automatically in an opinionated way? Or should it be user-configured?

How do we want to handle user input vs programmatic input? What kind of errors can we surface to the calling context which can help make the UX feel right?

example of where this has caused issues in the past:
https://github.com/mixmaxhq/app/pull/7505/files#diff-d32a3e6004a682c216ff83320b43464dR234 (private to Mixmaxers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant