fix(#753): API documentation for unittest.mock
#754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryant Finney <[email protected]>
bryant-finney
changed the title
unittest.mockunittest.mock
... by checking for the `__contains__` attribute Signed-off-by: Bryant Finney <[email protected]>
bryant-finney
changed the title
unittest.mockunittest.mock
mhils
reviewed
Oct 23, 2024
pdoc/doc.py
Outdated
| @@ -445,7 +445,7 @@ def _taken_from(self, member_name: str, obj: Any) -> tuple[str, str]: | |||
|
|
|||
| mod = _safe_getattr(obj, "__module__", None) | |||
| qual = _safe_getattr(obj, "__qualname__", None) | |||
| if mod and qual and "<locals>" not in qual: | |||
| if mod and hasattr(qual, "__contains__") and "<locals>" not in qual: | |||
There was a problem hiding this comment.
Do you think
Suggested change
| if mod and hasattr(qual, "__contains__") and "<locals>" not in qual: | |
| if mod and isinstance(qual, str) and "<locals>" not in qual: |
would maybe be more appropriate here?
There was a problem hiding this comment.
Ah yes, nice catch 👍 (should have checked the signature)
bryant-finney
added a commit
to bryant-finney/pdoc
that referenced
this pull request
Oct 23, 2024
... from @mhils during mitmproxy#754 Signed-off-by: Bryant Finney <[email protected]>
... from @mhils during mitmproxy#754 Signed-off-by: Bryant Finney <[email protected]>
bryant-finney
force-pushed
the
fix/753/unittest-mock
branch
from
2878ac5
to
09fbbae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #753
Resolve the
TypeErrorby testing for the__contains__attribute