fix: delete all non-test uses of usingnamespace
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR refactors libxev to avoid using
usingnamespacein favor of manually importing the relevant decls into their corresponding structs. i believe this change involves zero changes to the public API of libxev. in particular, the same functions should be exported, and their arguments have not changed.zig build teston my mac completes successfully, but of course i can only run so many of the tests locally.i have retained the instances of
usingnamespaceinvolvingtestdecls, partly because it is not immediately clear to me how to do without it, and partly because they don't, for instance, make using ZLS more difficult.