New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Minor) Incorrect packet name for core value requests #8

Open

brentyi opened this issue Mar 10, 2017 · 0 comments

Contributor

brentyi commented Mar 10, 2017

https://github.com/mit-racecar/vesc/blob/master/vesc_driver/src/vesc_packet.cpp#L240

This bit:

VescPacketRequestValues::VescPacketRequestValues() :
  VescPacket("RequestFWVersion", 1, COMM_GET_VALUES)

Should probably be:

VescPacketRequestValues::VescPacketRequestValues() :
  VescPacket("RequestValues", 1, COMM_GET_VALUES)

There's currently no functional difference (from what I can see), but this could cause problems in the future.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment