Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New loading screen does not display during game launch #20

Open
Bitl opened this issue Feb 14, 2023 · 14 comments
Open

New loading screen does not display during game launch #20

Bitl opened this issue Feb 14, 2023 · 14 comments

Comments

@Bitl
Copy link
Contributor

Bitl commented Feb 14, 2023

For some reason, the new loading bar is not appearing upon my mod's startup. I have replaced the gameui.dll and all files are in the proper directories. The mod is compiled in Debug mode.
image

@Blixibon
Copy link
Contributor

I worked around this by putting progress_enable into valve.rc before it runs the gamestartup command. It doesn't show up until it starts loading the background map however.

@Bitl
Copy link
Contributor Author

Bitl commented Feb 14, 2023

I worked around this by putting progress_enable into valve.rc before it runs the gamestartup command. It doesn't show up until it starts loading the background map however.

This doesn't seem to work if you only have a VTF background, sadly

@DasMaddi
Copy link
Collaborator

I'll check into this, along with the other tickets, probably this coming weekend when my schedule frees up a little more again.

@Bitl
Copy link
Contributor Author

Bitl commented Feb 15, 2023

update: it seems like the loading screen doesn't show up regardless if the game is loading initially or it's just loading a map.

@DasMaddi
Copy link
Collaborator

DasMaddi commented Feb 15, 2023

Are you using the provided GameUI dll? I verified that loading screens work just now (after the menu) On stock SDK2013. Might be something on your end.

As far as this ticket goes, I will check into it this weekend, may be an issue in a closed-source DLL.

@Bitl
Copy link
Contributor Author

Bitl commented Feb 17, 2023

Are you using the provided GameUI dll? I verified that loading screens work just now (after the menu) On stock SDK2013. Might be something on your end.

As far as this ticket goes, I will check into it this weekend, may be an issue in a closed-source DLL.

I am using the provided DLL. Maybe could be an issue with my implementation, but not sure

Here is a link to my repo if you want to verify:

https://github.com/FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013

@Bitl
Copy link
Contributor Author

Bitl commented Feb 17, 2023

Another thing: does the loading screen rely on any external files? Maybe missing files could be the issue?

@Bitl Bitl changed the title New loading screen doesn't happen on load New loading screen doesn't happen on map or game load Feb 17, 2023
@Bitl Bitl changed the title New loading screen doesn't happen on map or game load New loading screen doesn't seem to work on map or game load even with proper dll Feb 17, 2023
@Bitl
Copy link
Contributor Author

Bitl commented Feb 17, 2023

another thing: my project was first developed on a older version of Source SDK 2013 and it was updated fairly recently. However, I don't know if I updated enough of it for the loading screen to work. I'll see if updating my code more solves my issues, although I'm not sure if a updated SDK 2013 matters just yet.

@DasMaddi
Copy link
Collaborator

DasMaddi commented Feb 18, 2023

That is undoubtedly the issue. I tested this extensively before release on stock SDK2013 MP & SP, from the official Valve repo. we cannot guarantee any compatibility beyond that. the only known issue is the panel not displaying on game launch.

@DasMaddi DasMaddi changed the title New loading screen doesn't seem to work on map or game load even with proper dll New loading screen does not display during game launch Feb 18, 2023
@Bitl
Copy link
Contributor Author

Bitl commented Feb 18, 2023

That is undoubtedly the issue. I tested this extensively before release on stock SDK2013 MP & SP, from the official Valve repo. we cannot guarantee any compatibility beyond that. the only known issue is the panel not displaying on game launch.

Alright. Will definitely take a look at my repo then.

@Bitl
Copy link
Contributor Author

Bitl commented Mar 10, 2023

That is undoubtedly the issue. I tested this extensively before release on stock SDK2013 MP & SP, from the official Valve repo. we cannot guarantee any compatibility beyond that. the only known issue is the panel not displaying on game launch.

Alright. Will definitely take a look at my repo then.

Update on this. I just investigated the issue with a blank copy of Source SDK 2013 SP, and figured out that regardless of what you do with IsSteamDeck() in cdll_client_int.cpp, the game MUST use -gamepadui in order to show the new loading screen.

If you wish to make this ui be the default ui for your mod, use -gamepadui and don't modify anything unless you don't want the new loading screen.

image

Bitl referenced this issue in FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013 Mar 20, 2023
@DasMaddi
Copy link
Collaborator

DasMaddi commented Mar 24, 2023

By default, GamepaduUI reads from the command line in IsSteamDeck() in order to function. This is a holdover that we don't particularly have a better way of addressing; anyone who chooses to replace their old UI entirely is going to edit the code anyways.

I have clarified this in the readme with my latest commit, not sure why this wasn't previously documented.

As far as the bug for this particular issue ticket. I am not 100% sure why the loading screen does not display on startup. I will try to set aside some time to investigate.

@Bitl
Copy link
Contributor Author

Bitl commented May 27, 2023

Even if you remove or edit the IsSteamDeck() function in cdll_client_int.cpp, it seems like it will not use the new loading screen without -gamepadui. My theory is that the gameui.dll checks for -gamepadui in order for the loading screen to load, especially since the loading screen code is probably in the gameui.dll. Although, I don't really know how else that could be fixed without adding a convar or something to the dll's implementation of the loading screen, and then having everyone update their dlls.

The normal GamepadUI will function as a replacement UI if you disable the IsSteamDeck(), as you have stated above, but this won't apply for the loading screen as it will show the old one unless -gamepadui is specified.

@misyltoad
Copy link
Owner

Indeed, gameui.dll does check that.

Blixibon added a commit to Blixibon/HL2-GamepadUI that referenced this issue Jul 17, 2023
…firm-enhancement

Command-based confirm dialogs parent to current frame + support raw command strings (fixed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants