Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untie bonus maps and commentary buttons from game directory #1

Open
vrad-exe opened this issue Feb 12, 2023 · 2 comments
Open

Untie bonus maps and commentary buttons from game directory #1

vrad-exe opened this issue Feb 12, 2023 · 2 comments

Comments

@vrad-exe
Copy link
Contributor

The commentary and bonus maps buttons in the new game dialog are currently tied to hardcoded game directory strings, meaning they can never show up in mods. With this now being open source it's less of a concern because modders can edit the code to make the buttons always appear, but it'd still be nice to have the ability to enable them without having to compile a custom DLL.

It'd probably make the most sense to have it controlled by 2 booleans in schemechapterbutton.res, since that file is already loaded by the new game dialog.

@DasMaddi
Copy link
Collaborator

DasMaddi commented Feb 14, 2023

I can see the use-cases for this, however, in order to best preserve backwards compatibility with HL2/Portal/Episodic, I would want to have the scheme checks override the directory check, instead of the scheme entry being the only on-off switch, if that makes sense. @Joshua-Ashton any thoughts?

@vrad-exe
Copy link
Contributor Author

vrad-exe commented Feb 15, 2023

Yeah that's fine, the important thing is just giving mods a way to enable the buttons. The bonus maps button should probably also be #ifdef'd to only appear if the bonus maps menu is actually compiled in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants