Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend) : リモートユーザーの照会をオリジナルにリダイレクトするように (#12892) #14897

Merged

Conversation

momoirodouhu
Copy link
Contributor

@momoirodouhu momoirodouhu commented Nov 6, 2024

What

Fix #12892
リモートにいるユーザーの照会が来た時にオリジナルにリダイレクトさせる。

Additional info (optional)

e2eテストにはリモートユーザーを交えたテストはまだのようなのでtodoだけ追加してあります。
動くかどうかはcurl -H "accept: application/activity+json" -L "{URL}"で確認できます。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

e2eテストにリモートユーザー考慮のテストがなさそうなので。

次のコマンドで動くことは確認済みです。
curl "http://localhost:3000/@foo@bar" -H "accept: application/activity+json" -L
@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 39.54%. Comparing base (794cb9f) to head (45b64fe).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/server/ActivityPubServerService.ts 6.25% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14897      +/-   ##
===========================================
+ Coverage    39.47%   39.54%   +0.06%     
===========================================
  Files         1559     1559              
  Lines       196958   196970      +12     
  Branches      3563     3642      +79     
===========================================
+ Hits         77751    77885     +134     
+ Misses      118635   118513     -122     
  Partials       572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit a4c5ce1 into misskey-dev:develop Nov 9, 2024
31 of 32 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 9, 2024

🙏

@momoirodouhu momoirodouhu deleted the enhance-redirect-remote-actore branch November 9, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
2 participants