Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加、お知らせの画像URLを空にできない問題を修正 #10878

Merged
merged 10 commits into from
May 26, 2023
Merged

enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加、お知らせの画像URLを空にできない問題を修正 #10878

merged 10 commits into from
May 26, 2023

Conversation

chocolate-pie
Copy link
Contributor

@chocolate-pie chocolate-pie commented May 20, 2023 •
edited
Loading

#10657 と#10854 の解決

What

ハッシュタグのノート一覧ページから、そのハッシュタグで投稿できるボタンを追加し、お知らせの画像URLをからにできない問題を修正しました

output.mp4

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels May 20, 2023
@chocolate-pie chocolate-pie changed the title enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加 enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加、お知らせの画像URLをからにできない問題を修正 May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023 •
edited
Loading

Codecov Report

Merging #10878 (d63ac5d) into develop (cf46816) will not change coverage.
The diff coverage is n/a.

❗ Current head d63ac5d differs from pull request most recent head a593b82. Consider uploading reports for the commit a593b82 to get more accurate results

@@           Coverage Diff            @@
##           develop   #10878   +/-   ##
========================================
  Coverage    94.71%   94.71%           
========================================
  Files            2        2           
  Lines          454      454           
  Branches        59       59           
========================================
  Hits           430      430           
  Misses          24       24

@chocolate-pie chocolate-pie marked this pull request as ready for review May 20, 2023 23:35
@chocolate-pie chocolate-pie changed the title enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加、お知らせの画像URLをからにできない問題を修正 enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加、お知らせの画像URLを空にできない問題を修正 May 20, 2023
@syuilo syuilo merged commit 98aef97 into misskey-dev:develop May 26, 2023
@syuilo
Copy link
Member

syuilo commented May 26, 2023

🙏🏻

@chocolate-pie chocolate-pie deleted the pr-135 branch May 26, 2023 05:56
sasagar pushed a commit to sasagar/misskey that referenced this pull request Jun 5, 2023
@chocolate-pie @syuilo @sasagar
enhance: ハッシュタグのノート一覧ページから、そのハッシュタグで投稿するボタンを追加、お知らせの画像URLを空にできない問題を修正 (…
1560220 
…misskey-dev#10878)

* fix: お知らせの画像URLを空にできない問題を修正 (misskey-dev#10657)

* ハッシュタグのノート一覧ページからノートできるように(misskey-dev#10854)

* fix: 色々直した

* location.reloadを使わないように

* CHANGELOGを編集

* tweak

* Update tag.vue

---------

Co-authored-by: syuilo <[email protected]>
@Sayamame-beans Sayamame-beans mentioned this pull request Jun 14, 2024
Closed
@yuba yuba mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acid-chicken acid-chicken Awaiting requested review from acid-chicken

@EbiseLutica EbiseLutica Awaiting requested review from EbiseLutica

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chocolate-pie @syuilo