Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading images with firefox are broken with resistfingerprinting=true #13582

Open
1 task
spirillen opened this issue Mar 17, 2024 · 8 comments
Open
1 task
Labels
⚠️bug? This might be a bug

Comments

@spirillen
Copy link

💡 Summary

Every time I try to add a image to a post by either upload or copy/paste, the images are broken, but if I uses a different browser, things goes well.

However, when I uses the From uri the image are upload as supposed.

🥰 Expected Behavior

The images should in this text show the BSD devil

image

🤬 Actual Behavior

The images looks like this

image
image

https://matrix.rocks/files/18f75b42-d514-4d99-a184-93bfd48e6a92

📝 Steps to Reproduce

  1. Use FireFox-ESR with enhanced privacy
  2. Upload or Copy/paste any image type

💻 Frontend Environment

* Model and OS of the device(s): Ubuntu 22.03
* Browser: Firefox-esr
* Server URL: https://matrix.rocks/
* Misskey: v2024.3.1

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: Bash script
* Misskey: v2024.3.1
* Node: v21.7.1
* PostgreSQL: 15
* Redis: 7.x
* OS and Architecture: Linux xxx 5.15.0-100-generic #110-Ubuntu SMP UTC 2024 x86_64 GNU/Linux

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@spirillen spirillen added the ⚠️bug? This might be a bug label Mar 17, 2024
@acid-chicken
Copy link
Member

fyi https://bugzilla.mozilla.org/show_bug.cgi?id=1631673

@spirillen
Copy link
Author

fyi https://bugzilla.mozilla.org/show_bug.cgi?id=1631673

Thanks for the link and info, however My mind have already been in that direction, as I uses canvas-shadow https://addons.mozilla.org/en-GB/firefox/addon/no-canvas-fingerprinting/.

So have disabled all add-ons and restarted the browser for testing, and yes I do have the fingerPrinting enabled as default, but this should be overwritten by the domain specific rules

   "EnableTrackingProtection": {
            "Value": true,
            "Locked": false,
            "Cryptomining": true,
            "Fingerprinting": true,
            "EmailTracking": true
        },

20240317-2

@saschanaz
Copy link
Member

So have disabled all add-ons and restarted the browser for testing

Did you still see the problem after that? You can also try Troubleshoot Mode in about:support.

@spirillen
Copy link
Author

spirillen commented Mar 23, 2024

Did you still see the problem after that?

Yes

You can also try Troubleshoot Mode in about:support.

That is new to me , will have a look at it later. Thanks for the suggestion

Same results

image

@saschanaz
Copy link
Member

Alright, I can repro this with any PNG upload. Maybe this is related to OffscreenCanvas use? Would you mind filing an issue in https://bugzilla.mozilla.org/ and link back here?

@spirillen
Copy link
Author

Would you mind filing an issue in https://bugzilla.mozilla.org/ and link back here?

Kinda, As I have no intention to give them any of my mail addresses. But please do feel free to do so on my behalf.

A little side note: The problem also relates to .jp?g files.

@saschanaz
Copy link
Member

Just found https://bugzilla.mozilla.org/show_bug.cgi?id=1422862 and added this issue there.

@saschanaz saschanaz changed the title Uploading images with firefox are broken Uploading images with firefox are broken with resistfingerprinting=true Mar 29, 2024
@spirillen
Copy link
Author

and then we wait yet another year on a solution to a "major" problem....

Thanks for committing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

3 participants