Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mentions are recognized in wrong places #95

Open
Johann150 opened this issue Feb 6, 2022 · 1 comment
Open

mentions are recognized in wrong places #95

Johann150 opened this issue Feb 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Johann150
Copy link
Contributor

This issue is moved from misskey-dev/misskey#8050. I am not sure if this is something that can be supported, but maybe you can take a look.

💡 Summary

When mentioning a user with wrong syntax e.g. @用户@weibo.com MFM tries to parse the mention which results in an incorrect mention.

🙂 Expected Behavior

[
    TEXT(`@用户@weibo.com')
]

☹️ Actual Behavior

[
    TEXT(`@用户'),
    MENTION('weibo', null, '@weibo'),
    TEXT('.com')
]

🔧🤔 Possible Solution

Maybe requiring ^|\s before and $|\s after a mention?

@marihachi
Copy link
Contributor

marihachi commented Feb 8, 2022

メンションではない部分として明確にマッチすることで、問題を回避できるかも。
でも、まずは、Misskeyとしてこの部分をFediverseのメンションとしてサポートするかどうかを議論する必要があると思います。

@marihachi marihachi added the enhancement New feature or request label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants