Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing URLs from readme #290

Merged
merged 7 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/jwt-auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"license": "MIT",
"scripts": {
"build": "next build",
"build-temp-disabled": "next build",
"start": "next dev",
"lint": "next lint"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/jwt-auth/src/app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { PropsWithChildren } from "react";
import Script from "next/script";
import "../assets/style.css";

import { MiroSDKInit } from "../components/SDKInit";
import { MiroSDKInit } from "../components/SdkInit"; // Corrected the casing of the file name

export default function RootLayout({ children }: PropsWithChildren) {
return (
Expand Down
2 changes: 1 addition & 1 deletion examples/terms-modal-banner-dynamodb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Once you have finished all of the steps related to AWS in the [developer tutoria
appName: Terms Modal Banner DynamoDB
sdkVersion: SDK_V2
sdkUri: >-
https://dynamodb-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html
https://<your-s3-bucket-url>/webassets/app.html
scopes:
- identity:read
```
Expand Down
2 changes: 1 addition & 1 deletion examples/terms-modal-banner-s3/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Once you have finished all of the steps related to AWS in the [developer tutoria
appName: Terms Modal Banner S3
sdkVersion: SDK_V2
sdkUri: >-
https://s3-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html
https://<your-s3-bucket-url>/webassets/app.html
scopes:
- identity:read
```
Expand Down
4 changes: 3 additions & 1 deletion examples/webhooks-manager/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ export default function Main({
});

window.miro.board.ui.on("icon:click", openPanel);
return () => window.miro.board.ui.off("icon:click", openPanel);
return () => {
window.miro.board.ui.off("icon:click", openPanel);
};
}, []);

async function createWebhook(e: FormEvent<HTMLFormElement>) {
Expand Down
Loading