Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breakout rooms readme #240

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

horeaporutiu
Copy link
Contributor

add links to included features section to document all of the methods used in this app

@horeaporutiu horeaporutiu requested a review from a team as a code owner January 11, 2024 11:16
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-examples-wordle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 11:28am
webhooks-manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 11:28am

Copy link
Contributor

@mettin mettin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like its a bit of an overkill to mention all sub methods. Might be a bit intimidating. What was the reason for adding them?

examples/breakout-rooms/README.md Outdated Show resolved Hide resolved
@horeaporutiu horeaporutiu merged commit ac4dd61 into main Jan 11, 2024
4 checks passed
@horeaporutiu horeaporutiu deleted the update-breakout-rooms-readme branch January 11, 2024 12:47
dfosco pushed a commit that referenced this pull request Jan 24, 2024
* adding methods with line numbers

* remove attention from included features

* Update examples/breakout-rooms/README.md

Co-authored-by: Mettin Parzinski <[email protected]>

* adding yarn format linting

---------

Co-authored-by: Mettin Parzinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants