From 6cacde3c903e959d6e9b89a275b271ab7040ef54 Mon Sep 17 00:00:00 2001
From: Vincent Liu <shuntian.liu2@cloud.com>
Date: Wed, 28 Feb 2024 17:02:12 +0000
Subject: [PATCH 1/3] Check for list emptiness before checking variants

Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
---
 src/lib/pythongen.ml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/lib/pythongen.ml b/src/lib/pythongen.ml
index ead82af..70fbb74 100644
--- a/src/lib/pythongen.ml
+++ b/src/lib/pythongen.ml
@@ -213,10 +213,12 @@ let rec typecheck : type a. a typ -> string -> t list =
         variants
     in
     let check_contents =
-      List.fold_left
-        (fun acc x -> List.concat [ acc; check false x ])
-        (check true (List.hd variants_to_check))
-        (List.tl variants_to_check)
+      match variants_to_check with
+      | [] -> []
+      | v :: vs ->
+        List.fold_left
+          (fun acc x -> List.concat [ acc; check false x ])
+          (check true v) vs
     in
     let all_tags = List.map (fun (BoxedTag t) -> t.tname) variants in
     let pylist =

From d610d47bfebbea9b0b1707bfffe26a0ff52a0720 Mon Sep 17 00:00:00 2001
From: Vincent Liu <shuntian.liu2@cloud.com>
Date: Thu, 29 Feb 2024 11:21:33 +0000
Subject: [PATCH 2/3] Add unit test for pythongen code

This tests whether it can handle the case where a varaiant consist only
of zero-arg constructors.

Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
---
 tests/rpc/test_pythongen.ml | 47 +++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/tests/rpc/test_pythongen.ml b/tests/rpc/test_pythongen.ml
index 1544b03..0572169 100644
--- a/tests/rpc/test_pythongen.ml
+++ b/tests/rpc/test_pythongen.ml
@@ -67,6 +67,50 @@ module Interface (R : Idl.RPC) = struct
 end
 
 module IfCode = Interface (Codegen.Gen ())
+module UnitVInterface (R : Idl.RPC) = struct
+  open R
+
+  type unit_variant =
+    | Empty
+    | Hollow
+    | Vacant
+    | Void
+  [@@deriving rpcty]
+
+  let unit_variant_p = Idl.Param.mk ~name:"unit_variant" unit_variant
+  let int_p = Idl.Param.mk Rpc.Types.int
+
+  let discard_v =
+    R.declare
+      "discard_v"
+      [ "constant function taking a unit variant and discards it by returning an integer"
+      ]
+      (unit_variant_p @-> returning int_p Idl.DefaultError.err)
+
+  let implementation =
+    implement
+      { Idl.Interface.name = "UnitVInterface"
+      ; namespace = Some "UnitVInterface"
+      ; description =
+          [ "Unit variant interface which does absolutely nothing. Only used to test \
+             whether the pythongen code can handle variants with zero argument \
+             constructors."
+          ]
+      ; version = 1, 0, 0
+      }
+end
+
+module UnitVCode : sig
+  val implementation : unit -> Codegen.Interface.t
+end =
+  UnitVInterface (Codegen.Gen ())
+
+let unitv_interface = 
+  Codegen.Interfaces.create
+    ~name:"unitv"
+    ~title:"Unit Variant"
+    ~description:[ "Interface for Unit variant" ]
+    ~interfaces:[ UnitVCode.implementation () ]
 
 let interfaces =
   Codegen.Interfaces.create
@@ -146,6 +190,8 @@ let check_exceptions () =
   gen_python_bindings "python/bindings.py";
   run_cmd "Exceptions should be correctly generated" "python python/exn_test.py"
 
+let check_unit_variants () =
+  Pythongen.of_interfaces interfaces |> Pythongen.string_of_ts |> ignore
 
 let tests =
   [ ( "Check generated test interface bindings with pylint & pycodestyle"
@@ -154,4 +200,5 @@ let tests =
   ; "Check generated commandline bindings", `Slow, test_commandline
   ; "Check generated test class with commandline bindings", `Slow, check_test_class
   ; "Cehck generated exceptions", `Slow, check_exceptions
+  ; "Check python generation on variants with zero-arg constructors", `Quick, check_unit_variants
   ]

From 4f9b5d2b9ef494331eeab070422ba99ca982d82c Mon Sep 17 00:00:00 2001
From: Vincent Liu <shuntian.liu2@cloud.com>
Date: Thu, 29 Feb 2024 16:42:38 +0000
Subject: [PATCH 3/3] Fix typo in test_pythongen.ml

---
 tests/rpc/test_pythongen.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/rpc/test_pythongen.ml b/tests/rpc/test_pythongen.ml
index 0572169..6a5f586 100644
--- a/tests/rpc/test_pythongen.ml
+++ b/tests/rpc/test_pythongen.ml
@@ -199,6 +199,6 @@ let tests =
     , lint_bindings )
   ; "Check generated commandline bindings", `Slow, test_commandline
   ; "Check generated test class with commandline bindings", `Slow, check_test_class
-  ; "Cehck generated exceptions", `Slow, check_exceptions
+  ; "Check generated exceptions", `Slow, check_exceptions
   ; "Check python generation on variants with zero-arg constructors", `Quick, check_unit_variants
   ]