From 06f05fbe026fc6fc0fa57b20913019019fbfbb83 Mon Sep 17 00:00:00 2001 From: Hannes Mehnert Date: Sun, 5 Jun 2022 16:04:57 +0200 Subject: [PATCH 1/2] Remove "mutable" from Ack.Immediate.send_ack, since it is never mutated. --- src/tcp/ack.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tcp/ack.ml b/src/tcp/ack.ml index d12b99dda..0385ed2eb 100644 --- a/src/tcp/ack.ml +++ b/src/tcp/ack.ml @@ -37,7 +37,7 @@ end module Immediate : M = struct type t = { - mutable send_ack: Sequence.t Lwt_mvar.t; + send_ack: Sequence.t Lwt_mvar.t; mutable pushpending: bool; } From fd365ceb95e08f002b894196b476d16491bfec55 Mon Sep 17 00:00:00 2001 From: Hannes Mehnert Date: Sun, 5 Jun 2022 16:05:50 +0200 Subject: [PATCH 2/2] Remove silencing of deprecation alert. This raises no alerts. --- src/tcp/segment.ml | 2 -- src/tcp/user_buffer.ml | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/tcp/segment.ml b/src/tcp/segment.ml index 75872594d..c27e93673 100644 --- a/src/tcp/segment.ml +++ b/src/tcp/segment.ml @@ -14,8 +14,6 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. *) -[@@@ocaml.warning "-3"] - open Lwt.Infix let src = Logs.Src.create "tcp.segment" ~doc:"Mirage TCP Segment module" diff --git a/src/tcp/user_buffer.ml b/src/tcp/user_buffer.ml index 0b1f5325d..4ef002211 100644 --- a/src/tcp/user_buffer.ml +++ b/src/tcp/user_buffer.ml @@ -15,8 +15,6 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. *) -[@@@ocaml.warning "-3"] - open Lwt.Infix let lwt_sequence_add_l s seq =