Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt OCaml's code of conduct #2255

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Adopt OCaml's code of conduct #2255

merged 2 commits into from
Jun 29, 2023

Conversation

balat
Copy link
Contributor

@balat balat commented Jun 5, 2023

This PR proposes to add the OCaml Code of Conduct. Full text is available at https://github.com/ocaml/code-of-conduct, and a discussion around it is at https://discuss.ocaml.org/t/ocaml-community-code-of-conduct/10494.

@balat balat marked this pull request as ready for review June 6, 2023 08:48
Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


# Enforcement

This project follows the OCaml Code of Conduct [enforcement policy](https://github.com/ocaml/code-of-conduct/blob/main/CODE_OF_CONDUCT.md#enforcement).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to point to a list of contacts in to reach out in case of issue. I suggest pointing to https://github.com/orgs/mirage/teams/irmin-dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this list is private. What about putting all names and email addresses of current Irmin team members? Or do you prefer a more restristed list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having names and email addresses is indeed better - I'm happy to have mine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated the PR

@codecov-commenter
Copy link

Codecov Report

Merging #2255 (1c30a45) into main (0075198) will increase coverage by 0.04%.
The diff coverage is 92.68%.

❗ Current head 1c30a45 differs from pull request most recent head 3d25bdd. Consider uploading reports for the commit 3d25bdd to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   68.19%   68.23%   +0.04%     
==========================================
  Files         137      137              
  Lines       16674    16695      +21     
==========================================
+ Hits        11371    11392      +21     
  Misses       5303     5303              
Impacted Files Coverage Δ
bench/irmin-pack/trace_stat_summary_utils.ml 72.30% <0.00%> (ø)
src/irmin-pack/unix/store.ml 65.66% <80.00%> (+0.10%) ⬆️
src/irmin/tree.ml 81.49% <95.45%> (+0.32%) ⬆️
bench/irmin-pack/bench_common.ml 23.52% <100.00%> (ø)
bench/irmin-pack/trace_collection.ml 83.33% <100.00%> (+0.21%) ⬆️
src/irmin-pack/unix/file_manager.ml 85.78% <100.00%> (ø)
src/irmin-pack/unix/gc.ml 72.89% <100.00%> (+0.25%) ⬆️
src/irmin-test/store_watch.ml 30.76% <100.00%> (ø)
src/irmin/import.ml 75.92% <100.00%> (+0.92%) ⬆️
src/irmin/logging.ml 95.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samoht samoht merged commit b71c725 into main Jun 29, 2023
@samoht samoht deleted the coc branch June 29, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants