Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon-only button changes causes expando-row regression #692

Open
ppvg opened this issue Oct 21, 2024 · 0 comments
Open

Icon-only button changes causes expando-row regression #692

ppvg opened this issue Oct 21, 2024 · 0 comments
Labels
bug Something isn't working regression
Milestone

Comments

@ppvg
Copy link
Member

ppvg commented Oct 21, 2024

Current main has a breaking change on icon-only buttons. Previously this markup resulted in an icon-only button:

<button class="icon icon-?">Label text</button>

With current main, icon-only buttons need the icon-only class and a separate span for the button:

<button class="icon-inly"><span class="icon icon-?"></span>Label text</button>

While this change is intentional and desired for accessibility reasons, it causes a regression in the expando row, resulting in the label being visible:

image

@ppvg ppvg added bug Something isn't working regression labels Oct 21, 2024
@ppvg ppvg added this to the Manon v17 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

No branches or pull requests

1 participant