Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML instead of CSS pseudo-elements for presentational icons #433

Open
ppvg opened this issue Dec 5, 2023 · 2 comments
Open

Use HTML instead of CSS pseudo-elements for presentational icons #433

ppvg opened this issue Dec 5, 2023 · 2 comments
Assignees
Labels
a11y Accessibility fixes and improvements Form Component 'Form' Helper classes Component 'Helper classes' Icon Component 'Icon'
Milestone

Comments

@ppvg
Copy link
Member

ppvg commented Dec 5, 2023

From independent accessibility report, SC 2.4.6:

Op pagina components/accordion.html staan uitklapbare elementen. Deze elementen zijn opgemaakt als knoppen. De toegankelijkheidsnaam van deze knoppen is bijvoorbeeld "Voorbeeld-onderwerp 2 v". Het pijltje omhoog of de letter "v" als pijl naar beneden wordt dus ook onderdeel van de toegankelijkheidsnaam. Dit is hier eerder een icoon. Aangezien er met het aria-expanded-attribuut al aangegeven wordt dat dit element in- en uitgeklapt kan worden, kan het pijltje of de letter "v" beter verborgen worden. Dit kan door er een span-element omheen te plaatsen en hierop het attribuut aria-hidden="true" op te plaatsen.

Dit komt bijvoorbeeld ook voor op pagina components/filter.html.

Presentational icons, such as the arrows on expand/collapse buttons of accordions and filters, should be aria-hidden. This means they should be moved into the markup, since it is not possible to apply aria-hidden to CSS pseudo-elements (::before and ::after).

@ppvg ppvg added the a11y Accessibility fixes and improvements label Dec 5, 2023
@underdarknl
Copy link
Contributor

Should we also look at implementing this using details and summary tags instead of buttons and divs? Or at least also apply the css for 'our' accordions onto those tags.

@ppvg
Copy link
Member Author

ppvg commented May 21, 2024

We've had a report of these glyphs causing "an annoying Braille character", so this issue is confirmed to affect multiple assistive technologies.

@ppvg ppvg self-assigned this Aug 8, 2024
@HeleenSG HeleenSG added Icon Component 'Icon' labels Sep 19, 2024
@reinschaap reinschaap added Helper classes Component 'Helper classes' Form Component 'Form' labels Sep 26, 2024
@Davidemeer Davidemeer added this to the Fase 2 Manon milestone Sep 30, 2024
@HeleenSG HeleenSG self-assigned this Oct 1, 2024
@HeleenSG HeleenSG removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility fixes and improvements Form Component 'Form' Helper classes Component 'Helper classes' Icon Component 'Icon'
Projects
None yet
Development

No branches or pull requests

5 participants